fix: fix missing dist/**.d.ts #2687
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipcjs
reviewed
Nov 4, 2025
| "src/**/*.ts", | ||
| "src/**/*.json" | ||
| "dist/", | ||
| "src/" |
Collaborator
Author
There was a problem hiding this comment.
- src发到npm方便有的用户可能需要看源码，或者有时候用户希望引用包的部分功能，例如
import {x} from 'maptalks/src/xxx'注意maptalks不是所有的工具都有export的，有些工具可能就需要这种引入方式
- dts bundle的目的不是用在vscode这种环境下的，这个是为浏览器准备，后续maptalks会做playground，这个playground里会需要dts的，考虑到网络请求数量的问题，这时将所有的dts打包就必要了，否则那么多dts无限引入和嵌套，网络请求量太大了且还要各种依赖分析的
ipcjs
approved these changes
Nov 6, 2025
| "src/**/*.ts", | ||
| "src/**/*.json" | ||
| "dist/", | ||
| "src/" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2686