Skip to content

Conversation

@dnutiu
Copy link

@dnutiu dnutiu commented Feb 24, 2024

I'm new to Rust so sorry if I make mistakes.

It seems like the crate from crates.io is not synced to the Github repo and in order to get the example to compile I had to tweak it, please see the PR.

I also had to use the following line in my Cargo.toml.

bme680 = {git = "https://github.com/marcelbuesing/bme680.git", version = "0.6.0"}

@shufps
Copy link

shufps commented Jun 1, 2024

nice to see to have migrated to embedded hal 1.0.0

One thing:

for no_std that is required on eg STM32 the linux-embedded-hal should be put to dev-dependencies and not to the regular one.

And the other thing is, anyhow needs to be switched to no_std via:

[dependencies]
anyhow = { version = "1.0", default-features = false }

@dnutiu
Copy link
Author

dnutiu commented Jun 2, 2024

Hello @shufps

Thank you for taking the time to review my PR! I've stopped working on this for the moment, but this is a nice opportunity for anyone who wants to get involved to implement the changes.

@shufps
Copy link

shufps commented Jun 4, 2024

I used your PR successfully on a STM32 with embassy, works very well, thx a lot for this 🙌

Especially because embedded-hal 1.0.0 is used by embassy and it would have required work to migrate it from the alpha.

You saved me a lot of time 🥰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants