Remove ispart #95
Open
Remove ispart #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build/combine-specs.js
Outdated
| const debug = require('debug')('specdb.combine-specs'); | ||
| const util = require('./util'); | ||
| const combineUtil = require('./combine-util'); | ||
| const specTypes = ['CPU', 'Graphics Card', 'APU']; |
There was a problem hiding this comment.
instead of repeatedly calling specTypes.includes let's have a separate helper function eg isPart(v)
|
let's not duplicate the |
markasoftware
approved these changes
Oct 24, 2025
| 'https://specdb.info/about', | ||
| ]; | ||
| const dynamicSitemapUrls = Object.keys(_.pickBy(toReturn, v => v.isPart)).map(c => `https://specdb.info/${c}`); | ||
| const dynamicSitemapUrls = Object.keys(_.pickBy(toReturn, v => pure.isPart(v))).map(c => `https://specdb.info/${c}`); |
There was a problem hiding this comment.
v => pure.isPart(v) can be reduced to just pure.isPart
There was a problem hiding this comment.
Ahh okay. Thanks for being patient, you can probably tell I only do JS for spec db, never done it otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit to review is the commit from yesterday, the other is just removing it from the specs