Smart Targeting for Closest/Random #238
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Smart Targeting capabilities for closest and random target selection, plus some potential performance enhancements.
With Smart Last Target & Smart Targeting for closest and random enabled, when you use target a non-friendly, it will update your last harmful target instead of both harmful and beneficial. When you target a friendly target, it will update your last beneficial instead of both harmful and beneficial.
Along with refactoring the code so duplicate logic isn't spread across the codebase, consolidated all the duplicate filtering logic into centralized methods. The targeting proximity code is now more organized with clear separation of concerns between filtering, selection, and processing.
Also when determining the closest, the square root operation is dropped for better performance when calculating distances.