fix: API endpoint routing for LX/SX buttons on TradingView #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated contentScript.js to pass full URL to background script instead of just hostUrl. Updated background.js to use dynamic URL instead of hardcoded /placeorder endpoint. Both /api/v1/placeorder and /api/v1/placesmartorder now route correctly.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated contentScript.js to pass full URL to background script
Summary by cubic
Fixes API endpoint routing for LX/SX buttons on TradingView by moving API calls to a background service worker and sending the full URL from the content script. Both /api/v1/placeorder and /api/v1/placesmartorder now work and bypass CORS.
Written for commit a27c6f5. Summary will update automatically on new commits.