MLE-24892 Parameterizing image tags in Jenkinsfile #1855
Conversation
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR parameterizes MarkLogic image tags in the Jenkinsfile to enable dynamic specification of Docker images for regression testing, replacing hardcoded stage definitions with a flexible configuration approach.
Key changes:
- Introduced
MARKLOGIC_IMAGE_TAGSparameter for comma-delimited image tag specification - Replaced multiple hardcoded regression stages with a single parameterized stage that dynamically creates parallel test stages
- Removed commented-out reverse proxy regression stage
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Jenkinsfile
Outdated
| steps { | ||
| script { | ||
| def imageTags = params.MARKLOGIC_IMAGE_TAGS.split(',') | ||
| def imagePrefix = 'ml-docker-db-dev-tierpoint.bed-artifactory.bedford.progress.com/marklogic/' def parallelStages = [:] |
There was a problem hiding this comment.
The line contains two variable declarations without proper separation. The def parallelStages = [:] declaration should be on its own line for better readability.
| def imagePrefix = 'ml-docker-db-dev-tierpoint.bed-artifactory.bedford.progress.com/marklogic/' def parallelStages = [:] | |
| def imagePrefix = 'ml-docker-db-dev-tierpoint.bed-artifactory.bedford.progress.com/marklogic/' | |
| def parallelStages = [:] |
Jenkinsfile
Outdated
| script { | ||
| def imageTags = params.MARKLOGIC_IMAGE_TAGS.split(',') | ||
| def imagePrefix = 'ml-docker-db-dev-tierpoint.bed-artifactory.bedford.progress.com/marklogic/' def parallelStages = [:] | ||
| imageTags.each { tag -> |
There was a problem hiding this comment.
Inconsistent indentation: lines 250-251 use tabs while line 252 appears to have extra indentation. Ensure consistent indentation throughout the script block.
| imageTags.each { tag -> | |
| imageTags.each { tag -> |
rjrudin
force-pushed
the
feature/jenkins-2
branch
from
c0edbda to
ec9e8f6
Compare
No description provided.