-
Notifications
You must be signed in to change notification settings - Fork 4
MLE-25068: Support more configuration for log collection #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/1.1.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the log collection configuration system by allowing users to provide custom Fluent Bit configurations for inputs, filters, and parsers in addition to the previously supported outputs. The main goal is to provide more flexibility in log collection configuration while maintaining backward compatibility with default configurations.
Key changes:
- Refactored YAML indentation processing logic into a reusable
normalizeYAMLIndentationfunction - Added support for custom
Inputs,Filters, andParsersconfiguration fields - Removed the default Loki output configuration from the CRD schema
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/k8sutil/configmap.go | Extracted indentation logic into normalizeYAMLIndentation function and added conditional support for custom inputs, filters, and parsers configurations |
| api/v1/common_types.go | Added new Filters, Inputs, and Parsers string fields to LogCollection struct; removed default value annotation from Outputs field |
| config/crd/bases/marklogic.progress.com_marklogicgroups.yaml | Updated CRD schema to include new filters, inputs, and parsers fields; removed default Loki output configuration |
| config/crd/bases/marklogic.progress.com_marklogicclusters.yaml | Updated CRD schema to include new filters, inputs, and parsers fields; removed default Loki output configuration |
| charts/marklogic-operator-kubernetes/templates/marklogicgroup-crd.yaml | Updated Helm chart CRD template to include new fields and removed default output configuration |
| charts/marklogic-operator-kubernetes/templates/marklogiccluster-crd.yaml | Updated Helm chart CRD template to include new fields and removed default output configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rwinieski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Peng,
Don't we need to update the sample file to reflect the yaml format?
I've created another story dedicated to update the samples file |
2024a54 to
041bdb2
Compare
041bdb2 to
f63a977
Compare
No description provided.