Skip to content

Conversation

@pengzhouml
Copy link
Collaborator

No description provided.

@pengzhouml pengzhouml changed the title Feature/mle 25068 log format MLE-25068: Support more configuration for log collection Nov 5, 2025
@rwinieski rwinieski requested a review from Copilot November 6, 2025 10:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the log collection configuration system by allowing users to provide custom Fluent Bit configurations for inputs, filters, and parsers in addition to the previously supported outputs. The main goal is to provide more flexibility in log collection configuration while maintaining backward compatibility with default configurations.

Key changes:

  • Refactored YAML indentation processing logic into a reusable normalizeYAMLIndentation function
  • Added support for custom Inputs, Filters, and Parsers configuration fields
  • Removed the default Loki output configuration from the CRD schema

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pkg/k8sutil/configmap.go Extracted indentation logic into normalizeYAMLIndentation function and added conditional support for custom inputs, filters, and parsers configurations
api/v1/common_types.go Added new Filters, Inputs, and Parsers string fields to LogCollection struct; removed default value annotation from Outputs field
config/crd/bases/marklogic.progress.com_marklogicgroups.yaml Updated CRD schema to include new filters, inputs, and parsers fields; removed default Loki output configuration
config/crd/bases/marklogic.progress.com_marklogicclusters.yaml Updated CRD schema to include new filters, inputs, and parsers fields; removed default Loki output configuration
charts/marklogic-operator-kubernetes/templates/marklogicgroup-crd.yaml Updated Helm chart CRD template to include new fields and removed default output configuration
charts/marklogic-operator-kubernetes/templates/marklogiccluster-crd.yaml Updated Helm chart CRD template to include new fields and removed default output configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@rwinieski rwinieski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Peng,

Don't we need to update the sample file to reflect the yaml format?

@pengzhouml
Copy link
Collaborator Author

Hi Peng,

Don't we need to update the sample file to reflect the yaml format?

I've created another story dedicated to update the samples file

@pengzhouml pengzhouml requested a review from rwinieski November 6, 2025 18:43
@pengzhouml pengzhouml force-pushed the feature/MLE-25068-log-format branch from 2024a54 to 041bdb2 Compare November 7, 2025 07:22
@pengzhouml pengzhouml force-pushed the feature/MLE-25068-log-format branch from 041bdb2 to f63a977 Compare November 7, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants