-
Notifications
You must be signed in to change notification settings - Fork 4
MLE-25053 update config readme and sample files #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLE-25053 update config readme and sample files #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates configuration files to upgrade the fluent-bit container image from version 3.2.5 to 4.1.1, modifies sample configurations, and makes minor adjustments to build and documentation files.
Key changes include:
- Upgrading fluent-bit image version across test files, CRDs, sample configs, and API type definitions
- Updating log collection output configuration format from INI-style to YAML-style syntax
- Enabling persistence by default in quick-start sample and removing hugepages configuration from complete sample
Reviewed Changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/2_marklogic_cluster_test.go | Updates fluent-bit version in e2e test configuration |
| internal/controller/marklogicgroup_controller_test.go | Updates fluent-bit version constant and test instantiation |
| internal/controller/marklogiccluster_controller_test.go | Updates fluent-bit version in cluster controller test |
| config/samples/quick-start.yaml | Enables persistence by default |
| config/samples/minimal-production.yaml | Updates fluent-bit version and converts output config to YAML format |
| config/samples/complete.yaml | Updates fluent-bit version, converts output config to YAML, and removes hugepages entries |
| config/crd/kustomization.yaml | Comments out patches configuration line |
| config/crd/bases/marklogic.progress.com_marklogicgroups.yaml | Updates default fluent-bit version in CRD |
| config/crd/bases/marklogic.progress.com_marklogicclusters.yaml | Updates default fluent-bit version in CRD |
| charts/marklogic-operator-kubernetes/templates/marklogicgroup-crd.yaml | Updates default fluent-bit version in Helm chart template |
| charts/marklogic-operator-kubernetes/templates/marklogiccluster-crd.yaml | Updates default fluent-bit version in Helm chart template |
| api/v1/marklogicgroup_types.go | Updates default fluent-bit version in type definition |
| api/v1/marklogiccluster_types.go | Updates default fluent-bit version in type definition |
| api/v1/common_types.go | Updates default fluent-bit version in common types |
| README.md | Updates version numbers and security vulnerability notes |
| Makefile | Removes commented line and adds platform flag to docker build |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep the huge pages in the complete yaml file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made the fix. Will Try to merge to release branch for now
No description provided.