Skip to content

Conversation

@esoteric-ephemera
Copy link
Collaborator

@esoteric-ephemera esoteric-ephemera commented Dec 22, 2025

Consistent with, and dependent on emmet-core #1372, removing monty_decode options because these are now implicitly handled by document serdes

Requires some changes to the grain boundaries and structure graph serdes in emmet, and will need to wait until a version with the fixes in 1372 is released

No breaking changes: users will be given a warning if monty_decode is used as a kwarg

Also removing some legacy, unused kwargs (supports_versions - retrieving other versions may be a future client addition)

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.19%. Comparing base (2478637) to head (d40cb19).

Files with missing lines Patch % Lines
mp_api/client/core/client.py 75.00% 2 Missing ⚠️
mp_api/client/mprester.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1047      +/-   ##
==========================================
- Coverage   76.44%   76.19%   -0.25%     
==========================================
  Files          50       51       +1     
  Lines        2793     2798       +5     
==========================================
- Hits         2135     2132       -3     
- Misses        658      666       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants