-
Notifications
You must be signed in to change notification settings - Fork 51
[WIP] Add convenience method for obtaining blessed calculation for different functionals #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@shyuep starting this PR now. Need one last deployment this week before you and others can start testing. See TODOs above for my current plan for what to implement. |
|
Thanks |
|
Just want to quickly update on this. We have deployed twice in the last couple weeks, but are finding some significant performance problems due to a combination of structural issues with the data in the core DB, and a large volume of API use. This is not allowing nested data in the blessed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #880 +/- ##
==========================================
- Coverage 67.38% 67.11% -0.27%
==========================================
Files 49 49
Lines 2520 2533 +13
==========================================
+ Hits 1698 1700 +2
- Misses 822 833 +11 ☔ View full report in Codecov by Sentry. |
de7e2e6 to
3b87f94
Compare
|
Reviving this to clear out old PRs + ensure that API endpoints are working as intended. See emmet #1376 Will require emmet release + redeploy |
Summary
MaterialsResterfor obtaining blessed calculation entries for different functionalsTodos
ComputedStructureEntryMPRester**NOTE: This requires one last deployment of the API service to fix pagination.