Skip to content

fix literal underscore encoding #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix literal underscore encoding #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
180129c
fix literal underscore encoding
swhiteman Mar 6, 2022
3be8f99
.
swhiteman May 5, 2025
b0ab745
.
swhiteman May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion q.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
});
};

var regexUnsafeSymbols = /[\0-\x1F"-\),\.:-@\[-\^`\{-\uFFFF]/g;
var regexUnsafeSymbols = /[\0-\x1F"-\),\.:-@\[-_`\{-\uFFFF]/g;
Copy link
Owner

@mathiasbynens mathiasbynens May 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove \^?

Copy link
Author

@swhiteman swhiteman May 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me re-review.

Copy link
Author

@swhiteman swhiteman Aug 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally getting back to this. Yes, that was deliberate!

It isn't actually removing the caret ^ because you had the character range [ through ^ (U+005B to U+005E) and by substituting the _ (U+005F) the range is now U+005B to U+005F, still including U+005E.

Of course the character range

\[-_

could be further simplified to

\[-`

(U+005B to U+0060, inclusive) but was trying to be unintrusive.

Copy link
Author

@swhiteman swhiteman Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking in on this.

var encode = function(string) {
// Note: this assumes the input is already encoded into octets (e.g. using
// UTF-8), and that the resulting octets are within the extended ASCII
Expand Down
5 changes: 5 additions & 0 deletions tests/tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,11 @@
'ooh=3A_ahh',
'colons'
);
equal(
q.encode('my dog_has fleas'),
'my_dog=5Fhas_fleas',
'underscore roundtrip, disambiguate from original space'
)
raises(
function() {
// Note: “forgot” to UTF-8-encode first
Expand Down