Skip to content

Conversation

@vanditaMW
Copy link
Collaborator

@vanditaMW vanditaMW commented Sep 2, 2024

Added the "select-by-name" parameter to enable the CircleCI Test Splitting feature within the "run-tests" command.

image

I have conducted local testing, and the interactive workflow was reviewed to ensure proper integration. For more details, refer to the given Confluence page

Additionally, some checks are failing because changes are required in the genscript function to implement this feature. I have raised a pull request to address these changes. I will be adding the unit tests after the PR is merged.

Copy link
Member

@mw-hrastega mw-hrastega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest improving the description of the new select-by-name parameter. It seems that TestSuite.fromName does not support wildcards. We need to be clear what we mean by patterns here.

@vanditaMW vanditaMW requested a review from mcafaro September 5, 2024 15:01
@mcafaro
Copy link
Member

mcafaro commented Sep 9, 2024

Are tests going to be added to the test-deploy.yml for this new feature?

@vanditaMW
Copy link
Collaborator Author

Are tests going to be added to the test-deploy.yml for this new feature?

Yes I have added some test cases for this feature

@vanditaMW vanditaMW requested a review from mw-kapilg September 10, 2024 04:17
@nbhoski
Copy link
Member

nbhoski commented Sep 17, 2024

I think this should be merged only after genscript changes are published on SSD location.

@vanditaMW vanditaMW requested review from mcafaro and nbhoski and removed request for mw-kapilg September 17, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants