Skip to content

Conversation

@mw-hrastega
Copy link
Member

This pull request adds a new command parameter and example to README.md. The parameter and example were previously reviewed by Mark. But please take another look as sanity check.

Copy link
Member

@mcafaro mcafaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We should wait until the select-by-name input is actually in the orb before merging though.

@mw-hrastega
Copy link
Member Author

Looks good! We should wait until the select-by-name input is actually in the orb before merging though.

Good point. @mw-kapilg, could you add the missing parameter? Thanks!

Copy link
Member

@mw-kapilg mw-kapilg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Houman for creating this PR again! I'll take care of merging the implementation changes (just needs a final verification of successful pipeline run)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants