Skip to content

Conversation

@Code-Farmer-Ming
Copy link

Description:

Fixed gem work with new version matomo, changed the API call from get to post

@daniel-rikowski
Copy link

Thank you for the pull request.

I think, loosening the ActiveSupport constraint is the right call.

But why did you change the request method from GET to POST? Which problem does this solve?

@ovidiubite
Copy link

ovidiubite commented Feb 6, 2025

Thank you for the pull request.

I think, loosening the ActiveSupport constraint is the right call.

But why did you change the request method from GET to POST? Which problem does this solve?

Hey!

I was just checking out the gem, and found this PR.

Based on matomo documentation, when using an auth_token which has the Secure use only feature enabled, you won't be able to use it via a GET request. I'm assuming that's the reason behind this change.

@daniel-rikowski
Copy link

Sounds plausible.

If that is the case, personally I'd prefer to keep using GET and only use POST when an auth_token is provided. At least until I get some more feedback on that this doesn't break anything for other users and/or use cases.

Anyway, I no longer have merge authorization, so it doesn't actually matter...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants