feat: LiveView for exploring daily schedules for different bus routes #2842
+288
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecristen
approved these changes
Dec 16, 2025
Collaborator
thecristen
left a comment
thecristen
left a comment
There was a problem hiding this comment.
To use internally, can you add some comments into the code itself? You have a nice description in the PR but someone coming cold to this code is not going to have any idea what's going on. 😅
| date_set = schedule.dates |> MapSet.new() | ||
|
|
||
| [ | ||
| {fn -> MapSet.subset?(date_set, MapSet.new([~D[2025-11-27]])) end, "Thanksgiving"}, |
Collaborator
There was a problem hiding this comment.
For the holidays, I'm curious why you didn't want to use the added_date_notes
Contributor
Author
There was a problem hiding this comment.
Hummm - I don't remember, tbh!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No ticket, but we've been doing a lot of thinking about services, and how they interact to form daily schedules.
This creates a preview page that can be used to explore which services are active for a given route on the same days, thus dividing the days in a rating up into different days with the exact same trips (same by trip ID, not same by which stops are visited when).
See the example below:
This isn't intended for riders - it's just another way to examine schedules - maybe we can clean this up and combine "daily schedules" into something that we do want to show riders.