feat(SF2.0/UpcomingDepartures): Show cancelled CR trips, crossed out #2855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlarson
added
dev-green
joshlarson
force-pushed
the
jdl/sf2.0/ud/cancelled-cr-trips
branch
from
ad700d9 to
5907f6a
Compare
joshlarson
force-pushed
the
jdl/sf2.0/ud/cancelled-cr-trips
branch
from
5907f6a to
a4aea9a
Compare
joshlarson
force-pushed
the
jdl/sf2.0/ud/refactor-predictions-schedules-fetching
branch
from
3703a0d to
247158b
Compare
joshlarson
force-pushed
the
jdl/sf2.0/ud/cancelled-cr-trips
branch
from
c95afab to
f1dfa3f
Compare
joshlarson
force-pushed
the
jdl/sf2.0/ud/refactor-predictions-schedules-fetching
branch
from
247158b to
945f281
Compare
joshlarson
force-pushed
the
jdl/sf2.0/ud/cancelled-cr-trips
branch
from
f1dfa3f to
7477b73
Compare
Base automatically changed from
jdl/sf2.0/ud/refactor-predictions-schedules-fetching
to
main
December 31, 2025 21:11
joshlarson
force-pushed
the
jdl/sf2.0/ud/cancelled-cr-trips
branch
from
7477b73 to
7063ac0
Compare
thecristen
approved these changes
Jan 2, 2026
Collaborator
thecristen
left a comment
thecristen
left a comment
There was a problem hiding this comment.
I'm curious if we want to give schedule_relationship == :skipped the same treatment? But we can add that later.
|
|
||
| defp cancelled?(%PredictedSchedule{schedule: schedule, prediction: prediction}) | ||
| when prediction != nil and schedule != nil do | ||
| schedule_time = prediction_time(schedule) |
Collaborator
There was a problem hiding this comment.
nit: trying to find a prediction time from a schedule seems kinda funny
| defp prediction_time(%{departure_time: time}), do: time | ||
|
|
||
| defp prediction_time(%PredictedSchedule{ | ||
| prediction: %Prediction{arrival_time: nil, departure_time: nil}, |
Collaborator
There was a problem hiding this comment.
I commented on this offline but I was curious why not use prediction schedule_relationship here. However I don't consider this logic incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Ticket: [SF/UD] CR: Include cancelled trips (crossed out)