ColorPickerHueRing improvements
#87
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new option to toggle between the always win pan gesture recognizer with a new recognizer that checks if the pointer event is inside the ring. This allows direct users of the `ColorPickerHueRing` to be able to let events that are in the bounds of the hue ring but not in the ring to reach parents of the widget.
This event is triggered when the users finishes the pan gesture on the ring. This allows direct users of `ColorPickerHueRing` to be notified when the user stops interacting with the hue ring and act accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new option to toggle between the always win pan gesture recognizer with a new recognizer that checks if the pointer event is inside the ring.
And a
onEndcallback that is called when the users finishes the pan gesture on the ring.I implemented this options for a project I'm working on and since it might be useful to more people decided on upstreaming them, if this changes aren't desired feel free to close the PR.