PHPStan level 8

Author: swissspidy

phpstan.neon.dist

@@ -1,5 +1,5 @@
 parameters:
-	level: 7
+	level: 8
 	paths:
 		- ai-command.php
 		- src/

src/AI/AiClient.php

@@ -20,7 +20,7 @@
 /**
  * AI client class.
  *
- * @phpstan-type ToolDefinition array{name: string, description: string, parameters: array<string, array<string, mixed>>, server: string, callback: callable}
+ * @phpstan-type ToolDefinition array{name: string, description: string|null, parameters: array<string, array<string, mixed>>, server: string, callback: callable}
  */
 class AiClient {
 	private bool $needs_approval = true;

src/MCP/HttpTransport.php

@@ -158,7 +158,7 @@ private function instantiateJsonRpcMessage( array $data ): JsonRpcMessage {
 						return new JsonRpcMessage(
 							new JSONRPCError(
 								'2.0',
-								isset( $data['id'] ) ? new RequestId( $data['id'] ) : null,
+								new RequestId( $data['id'] ?? 0 ),
 								new JsonRpcErrorObject(
 									$error_data['code'],
 									$error_data['message'],
@@ -172,7 +172,7 @@ private function instantiateJsonRpcMessage( array $data ): JsonRpcMessage {
 					return new JsonRpcMessage(
 						new JSONRPCResponse(
 							'2.0',
-							isset( $data['id'] ) ? new RequestId( $data['id'] ) : null,
+							new RequestId( $data['id'] ?? 0 ),
 							$data['result']
 						)
 					);