Making key decryption nicer #2344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
force-pushed
the
why-do-i-even-care
branch
2 times, most recently
from
49ac2fd to
46b5b6a
Compare
nvlsianpu
reviewed
Jun 25, 2025
| #endif | ||
| #if !defined(MCUBOOT_ENCRYPT_KW) | ||
| uint8_t *cp; | ||
| uint8_t *cpend; | ||
| size_t len; |
There was a problem hiding this comment.
code which is using depends on #if defined(MCUBOOT_ENCRYPT_RSA)
There was a problem hiding this comment.
Thanks. I have converted it to draft, because this is unfinished. I have accidentally pushed it as non-draft.
de-nordic
force-pushed
the
why-do-i-even-care
branch
from
46b5b6a to
096f97d
Compare
nordicjm
requested changes
Jul 22, 2025
| @@ -35,6 +35,7 @@ extern "C" { | |||
|
|
|||
| #if defined(MCUBOOT_USE_TINYCRYPT) | |||
| typedef uintptr_t bootutil_ecdh_p256_context; | |||
| typedef bootutil_ecdh_p256_context bootutil_key_xchange_ctx; | |||
boot/bootutil/src/encrypted.c
Outdated
| uint8_t private_key[EC_PRIVK_LEN]; | ||
| uint8_t counter[BOOT_ENC_BLOCK_SIZE]; | ||
| #endif | ||
| #if !defined(MCUBOOT_ENCRYPT_KW) | ||
| bootutil_key_xchange_ctx pk_ctx; |
de-nordic
force-pushed
the
why-do-i-even-care
branch
from
096f97d to
4a842c4
Compare
nordicjm
reviewed
Jul 22, 2025
boot/bootutil/src/encrypted.c
Outdated
| uint8_t private_key[EC_PRIVK_LEN]; | ||
| uint8_t counter[BOOT_ENC_BLOCK_SIZE]; | ||
| #endif | ||
| #if !defined(MCUBOOT_ENCRYPT_KW) | ||
| bootutil_key_exchange_ctx pk_ctx; |
There was a problem hiding this comment.
this line still weird spacing: bootutil_key_exchange_ctx pk_ctx; 3 spaces
The commit uses typedef to define common name for key exchange in order to reduce number of local definitions and #ifdef in code. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
Allows to reuse size_t variables. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
de-nordic
force-pushed
the
why-do-i-even-care
branch
from
4a842c4 to
dea8c4c
Compare
nordicjm
approved these changes
Jul 23, 2025
nvlsianpu
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.