bootutil: Drop slot number and boot_state from most boot_enc functions #2501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
force-pushed
the
no-bs-slot-in-boot-enc
branch
from
b399465 to
f5ec550
Compare
Step forward in reducing entanglement between internal APIs. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
de-nordic
force-pushed
the
no-bs-slot-in-boot-enc
branch
from
f5ec550 to
13e5113
Compare
nordicjm
approved these changes
Oct 20, 2025
|
|
||
| /* Already loaded... */ | ||
| if (enc_state[slot].valid) { | ||
| if (boot_enc_valid(enc_state)) { |
There was a problem hiding this comment.
not for this PR but in future we need to do rework the code and do expression checks properly, e.g. if (boot_enc_valid(enc_state) == true) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step forward in reducing entanglement between internal APIs.