Narrow VersionValue
to omit true
values
#27426
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BCD's published types don't match the JSON Schema; this PR partially fixes this.
Test results and supporting details
VersionValue
has the typestring | boolean | null
; it should have the typestring | false
.Unfortunately, setting
VesionValue
tostring | false
causes several type errors in linter code. And it's not just dead code either; replacing placestrue
ornull
returns into thrown exceptions causes many errors.Related issues
null
andtrue
version values #24174 (comment)