Skip to content

Conversation

ddbeck
Copy link
Contributor

@ddbeck ddbeck commented Jul 28, 2025

Summary

BCD's published types don't match the JSON Schema; this PR partially fixes this.

Test results and supporting details

VersionValue has the type string | boolean | null; it should have the type string | false.

Unfortunately, setting VesionValue to string | false causes several type errors in linter code. And it's not just dead code either; replacing places true or null returns into thrown exceptions causes many errors.

Related issues

@github-actions github-actions bot added infra Infrastructure issues (npm, GitHub Actions, releases) of this project scripts Issues or pull requests regarding the scripts in scripts/. size:xs [PR only] 0-6 LoC changed labels Jul 28, 2025
Copy link
Contributor

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

@Elchi3 Elchi3 requested a review from queengooborg July 31, 2025 09:10
@Elchi3
Copy link
Member

Elchi3 commented Jul 31, 2025

Seems like #27428 is a PR that goes the extra miles and should be reviewed instead.

@ddbeck
Copy link
Contributor Author

ddbeck commented Aug 12, 2025

I added "closes" text to the description of the other PR. If/when it merges, this one ought to be automatically closed.

@queengooborg
Copy link
Contributor

Actually, why don't we just close this PR now and focus on reviewing the other PR?

@ddbeck
Copy link
Contributor Author

ddbeck commented Aug 14, 2025

I didn't close this one because it's where the actual bug is reported. It's notionally a PR but it's also the issue for the bug itself. It's not fixed and isn't a wontfix (presumably), so I figured "closes" was the best way to tell the history of the changes here (and for me personally, this PR being resolved closed would be a signal to start deleting the code that this bug is a blocker on).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infrastructure issues (npm, GitHub Actions, releases) of this project scripts Issues or pull requests regarding the scripts in scripts/. size:xs [PR only] 0-6 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants