Update main.js #81
Open
Update main.js #81
+27
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unnecessary code removed. No need to declare the 'self' variable - we already have 'this' for this purpose No need to declare a constructor - JavaScript will call super automatically if no constructor is declared No need to convert the node list to an array - we have 'for' loops that can iterate over node lists directly
Member
|
Thanks for the submission! @wbamberg you touched these last, do you want to have a quick look? |
pepelsbey
requested changes
Dec 18, 2025
Member
pepelsbey
left a comment
pepelsbey
left a comment
There was a problem hiding this comment.
Thank you for the effort to improve the demo! I would only suggest keeping the code style intact (single/double quotes) and only leaving the meaningful changes. Basically, we use Prettier's default config.
Also, there are many ways of doing the same thing in JS, and some of them improve in time, once we get new features or the browser support gets better. Others stay as a viable alternative and are just a matter of taste. I would suggest reviewing your suggestions from that perspective as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unnecessary code removed.