Feat: Implement file handling #93
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdouchement
reviewed
Nov 3, 2022
| // | ||
| files := &files{} | ||
| v1restricted.POST("/files/valet-tokens", files.ValetTokens) | ||
| // Following endpoints are authorized via valet token |
There was a problem hiding this comment.
So we should do something like:
v1valet := v1.Group("")
v1valet.Use(a valet middleware for authentication)
v1valet.POST("/files/upload/create-session", files.CreateUploadSession)
internal/server/files.go
Outdated
| // TODO: Check format of fileId (Security) | ||
| // TODO: Allow custom path in config | ||
| // TODO: Subfolders for each user (Compatible format with official server) | ||
| return "/etc/standardfile/database/" + token.FileId |
There was a problem hiding this comment.
Do we have the UserID somewhere to add one more namespace in the path?
There was a problem hiding this comment.
The UserID could be derived from token.Authorization.
Co-authored-by: mdouchement <marc.douchement@gmail.com>
mdouchement
reviewed
Feb 17, 2025
| return nil, errors.New("Invalid path") | ||
| } | ||
| // TODO: Allow custom path in config | ||
| // TODO: Subfolders for each user (Compatible format with official server) |
There was a problem hiding this comment.
go1.24 added https://pkg.go.dev/os#Root which helps to improve filesystem security.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented support for file upload/download in Standard Notes and like to share my solution. Due to time issues some things are currently missing.
TODO:
FileIdby client is a valid UUIDv1valetmiddleware for authentication