Add namespace metadata option in templates #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets the namespace key in metadata for all kubernetes manifests. The `.Release.Namespace` is a built-in variable in helm, that can be passed with` --namespace` on `install` or `template` step. If not set it defaults to `default`. *Why?* When using `helm install` with the `--namespace` argument the templates are applied into the chosen namespace. When using helm only as a template engine, in combination with GitOps tools like Flux, the namespace property must be set in the rendered manifests to be applied. For `--namespace` to have an effect when using `helm template`, it must be present like this in the templates. This change should not have any effect/change for `helm install` approach as far as I know.
|
@meilisearch sync-manifest |
brunoocasali
approved these changes
Feb 17, 2025
meili-bors bot
added a commit
that referenced
this pull request
Feb 17, 2025
247: Add namespace metadata option in templates r=brunoocasali a=MannerMan This sets the namespace key in metadata for all kubernetes manifests. The `.Release.Namespace` is a built-in variable in helm, that can be passed with `--namespace` on `install` or `template` step. If not set it defaults to `default`. **Why?** When using `helm install` with the `--namespace` argument the templates are applied into the chosen namespace. When using helm only as a template engine, in combination with GitOps tools like Flux, the namespace property must be set in the rendered manifests to be applied. For `--namespace` to have an effect when using `helm template`, it must be present like this in the templates. This change should not have any effect/change for `helm install` approach as far as I know. # Pull Request ## Related issue Possibly a fix for #230 ## What does this PR do? - Sets the namespace key in metadata for all kubernetes manifests ## PR checklist Please check if your PR fulfills the following requirements: - [ x ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [ x ] Have you read the contributing guidelines? - [ x ] Have you made sure that the title is accurate and descriptive of the changes? Co-authored-by: Oscar <oscar@eth1.nu> Co-authored-by: Bruno Casali <brunoocasali@gmail.com> Co-authored-by: brunoocasali <brunoocasali@users.noreply.github.com>
|
Build failed: |
|
@brunoocasali or @MannerMan can you fix the conflict please? sorry for that |
|
This is a bit more complex than just fixing the conflicts @curquiza the change breaks the test, and I didn't find a solution at that time. I need to get back to this when I got some time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the namespace key in metadata for all kubernetes manifests. The
.Release.Namespaceis a built-in variable in helm, that can be passed with--namespaceoninstallortemplatestep. If not set it defaults todefault.Why?
When using
helm installwith the--namespaceargument the templates are applied into the chosen namespace.When using helm only as a template engine, in combination with GitOps tools like Flux, the namespace property must be set in the rendered manifests to be applied. For
--namespaceto have an effect when usinghelm template, it must be present like this in the templates.This change should not have any effect/change for
helm installapproach as far as I know.Pull Request
Related issue
Possibly a fix for #230
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements: