Skip to content

fix: accessibility issue with slider ariaLabelledBy #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: accessibility issue with slider ariaLabelledBy #1983

wants to merge 1 commit into from

Conversation

@DiljohnSingh
Copy link

@DiljohnSingh DiljohnSingh commented Nov 14, 2025

Pull request type

Bug fix (non-breaking change which fixes an issue)

Screenshot 2025-11-14 at 12 27 36

Description

  • Team discovered an accessibility issue with slider. Slider handle is not linked to the label
  • Added the missing aria-labelledby using the id provided
  • Updated the snapshots

What should be covered while testing?

  • You should see aria-labelledby with the same value as id of associated label component.
  • Test cases should be passing.
  • Turn on Screen reader and navigate to handle on any slider. It should announce the label text.

@DiljohnSingh DiljohnSingh requested a review from a team as a code owner November 14, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

slider-web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@DiljohnSingh