Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Updated Go to 1.21, and update relevant pkgs #111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AryanSharma9917
Copy link

Notes for Reviewers

This PR fixes #108

Signed commits

  • Yes, I signed my commits.

@welcome
Copy link

welcome bot commented Sep 15, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@AryanSharma9917
Copy link
Author

@theBeginner86, could you please give this PR a look?

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Copy link
Member

@theBeginner86 theBeginner86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theBeginner86
Copy link
Member

Don't forget to run go mod tidy after updating go mod 👍

@theBeginner86
Copy link
Member

theBeginner86 commented Oct 22, 2023

@AryanSharma9917
Will you please consider fixing DCO checks? https://github.com/meshery/meshery-cpx/runs/17937243510

@theBeginner86 theBeginner86 added the area/ci Continuous Integration / Build and Release label Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/ci Continuous Integration / Build and Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chore] update Go to 1.21, and update relevant pkgs
2 participants