Use a base class for the ASM Compilers, again #15126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be able to hold some shared state between the different ASM compilers (or should that be assemblers?)
dcbaker
force-pushed
the
submit/asm-parser-compiler-class-v2
branch
from
441702d to
fb2b8f1
Compare
It really isn't a sanity check that a specific compiler doesn't work on a specific platform. This re-implements the check as a shared component in the ASMCompiler base class, which has the advantage of code sharing.
dcbaker
force-pushed
the
submit/asm-parser-compiler-class-v2
branch
from
fb2b8f1 to
8cc9c68
Compare
|
given that this is a fixed version of a previously reviewed and merged patch, I'm planning to merge this on Wednesday unless someone objects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously reverted due to regressions, but should now be cleaned up and ready for merge.