cmake: Set CMAKE_INSTALL_LIBDIR explicitly #15141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no point in doing so as it can be readily obtained from the environment. This in preparation of extracting more installation location from the environment.
dnicolodi
force-pushed
the
cmake-libdir
branch
from
8507714 to
b386447
Compare
CMake and Meson may disagree on the default value of the libdir
installation path. This results in shared libraries installed in the
default location not assigned to the {libdir_shared} install location
by the Meson CMake interpreter. This results in wrong install plan
metadata and in those libraries being installed in the wrong location.
Fixes mesonbuild#12960.
dnicolodi
force-pushed
the
cmake-libdir
branch
from
b386447 to
8aecc0c
Compare
|
I think this solves #13931 too |
|
I don't see how this patch may cause the CI failure. Any idea is welcomed. |
dcbaker
approved these changes
Oct 20, 2025
|
That looks more like a flake in the CI than a legitimate failure to me |
|
The tests are all green now. Is there anything left to do before this can be merged? |
|
Is it planned for this to land in release 1.9.2 or only in 1.10.0 ? Just checking to mark the associated meson-python test with the correct version conditional. |
|
It's not currently tagged for 1.9 backport, so currently just in 1.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake and Meson may disagree on the default value of the libdir installation path. This results in shared libraries installed in the default location not assigned to the {libdir_shared} install location by the Meson CMake interpreter. This results in wrong install plan metadata and in those libraries being installed in the wrong location.