Skip to content

fetchById throw error if document does not exists by given id #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fetchById throw error if document does not exists by given id #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 11 additions & 14 deletions src/module/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,22 +447,19 @@ export default function (Firebase: any): AnyObject {
})
},
async fetchById ({ dispatch, getters, state }, id) {
try {
if (!id) throw 'missing-id'
if (!getters.collectionMode) throw 'only-in-collection-mode'
const ref = getters.dbRef
const _doc = await ref.doc(id).get()
if (!_doc.exists) {
if (state._conf.logging) {
throw `Doc with id "${id}" not found!`
}
if (!id) throw 'missing-id'
if (!getters.collectionMode) throw 'only-in-collection-mode'
const ref = getters.dbRef
const _doc = await ref.doc(id).get()
if (!_doc.exists) {
if (state._conf.logging) {
return logError(`Doc with id "${id}" not found!`)
}
const doc = getters.cleanUpRetrievedDoc(_doc.data(), id)
dispatch('applyHooksAndUpdateState', { change: 'added', id, doc })
return doc
} catch (e) {
return logError(e)
throw `Doc with id "${id}" not found!`
}
const doc = getters.cleanUpRetrievedDoc(_doc.data(), id)
dispatch('applyHooksAndUpdateState', { change: 'added', id, doc })
return doc
},
applyHooksAndUpdateState (
// this is only on server retrievals
Expand Down