[Logging] Thread names to actor isntances #1731
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add enough information to Instance objects so they can produce a qualified name for themselves. Example:
```
"<root>.<tests.test_python_actors.Named the_name{'f': 0/2}>"
```
The name is the full path through their creators to the root actor, along with class names and given names for each actor.
Two follow ups:
1. get this string into user logging loggers so any log they print includes what actor it is running under.
2. Use this information when creating a supervision exceptions so that we producing a nicely formatted error message.
Differential Revision: [D85988370](https://our.internmc.facebook.com/intern/diff/D85988370/)
**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85988370/)!
[ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Oct 31, 2025
Add enough information to Instance objects so they can produce a qualified name for themselves. Example:
```
"<root>.<tests.test_python_actors.Named the_name{'f': 0/2}>"
```
The name is the full path through their creators to the root actor, along with class names and given names for each actor.
Two follow ups:
1. get this string into user logging loggers so any log they print includes what actor it is running under.
2. Use this information when creating a supervision exceptions so that we producing a nicely formatted error message.
Differential Revision: [D85988370](https://our.internmc.facebook.com/intern/diff/D85988370/)
**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85988370/)!
ghstack-source-id: 320185124
Pull Request resolved: #1731
meta-cla
bot
added
the
CLA Signed
This was referenced Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add enough information to Instance objects so they can produce a qualified name for themselves. Example:
The name is the full path through their creators to the root actor, along with class names and given names for each actor.
Two follow ups:
get this string into user logging loggers so any log they print includes what actor it is running under.
Use this information when creating a supervision exceptions so that we producing a nicely formatted error message.
Differential Revision: D85988370
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!