Skip to content

Commit 7420484

Browse files
TroyGardenfacebook-github-bot
authored andcommitted
fix upload-artifact v4 issue in build dynamic embedding wheel (#2754)
Summary: Pull Request resolved: #2754 # context * TorchRec's OSS workflow "build dynamic embedding wheels" has been [failing](https://github.com/pytorch/torchrec/actions/runs/13416363464/job/37478091546) due to an upgrading of upload action [bug report](actions/upload-artifact#506) * we saw similar error message as below ``` Run actions/upload-artifact@v4 With the provided path, there will be 1 file uploaded Artifact name is valid! Root directory input is valid! Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run ``` # solution * as described in this [migration.md](https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md), adding additional job (merge) the artifacts. Reviewed By: aliafzal Differential Revision: D69904715 fbshipit-source-id: 6c84275fd6753fe7887fa26ea4c3817b8ab551c1
1 parent d2ddc21 commit 7420484

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

.github/workflows/build_dynamic_embedding_wheels.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,4 +57,15 @@ jobs:
5757
- name: Upload wheels
5858
uses: actions/upload-artifact@v4
5959
with:
60+
name: artifact-${{ matrix.os }}-${{ matrix.pyver }}-cu${{ matrix.cuver }}
6061
path: wheelhouse/*.whl
62+
63+
merge:
64+
runs-on: ubuntu-latest
65+
needs: build_wheels
66+
steps:
67+
- name: Merge Artifacts
68+
uses: actions/upload-artifact/merge@v4
69+
with:
70+
name: artifact
71+
pattern: artifact-*

0 commit comments

Comments
 (0)