Skip to content

Typo fix #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Typo fix #3449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions torchrec/distributed/batched_embedding_kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,10 +337,10 @@ def _populate_zero_collision_tbe_params(
table_names = [table.name for table in config.embedding_tables]
l2_cache_size = tbe_params["l2_cache_size"]
if "kvzch_eviction_trigger_mode" in tbe_params:
eviction_tirgger_mode = tbe_params["kvzch_eviction_trigger_mode"]
eviction_trigger_mode = tbe_params["kvzch_eviction_trigger_mode"]
tbe_params.pop("kvzch_eviction_trigger_mode")
else:
eviction_tirgger_mode = 2 # 2 means mem_util based eviction
eviction_trigger_mode = 2 # 2 means mem_util based eviction
for i, table in enumerate(config.embedding_tables):
policy_t = table.virtual_table_eviction_policy
if policy_t is not None:
Expand Down Expand Up @@ -409,7 +409,7 @@ def _populate_zero_collision_tbe_params(
f"Unsupported eviction policy {policy_t} for table {table.name}"
)
eviction_policy = EvictionPolicy(
eviction_trigger_mode=eviction_tirgger_mode,
eviction_trigger_mode=eviction_trigger_mode,
eviction_mem_threshold_gb=l2_cache_size,
eviction_strategy=eviction_strategy,
counter_thresholds=counter_thresholds,
Expand Down
Loading