Skip to content

Allow running shell script from fbpkg #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Allow running shell script from fbpkg #1010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion torchx/components/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ def sh(
env: Optional[Dict[str, str]] = None,
max_retries: int = 0,
mounts: Optional[List[str]] = None,
entrypoint: Optional[str] = None,
) -> specs.AppDef:
"""
Runs the provided command via sh. Currently sh does not support
Expand All @@ -100,6 +101,7 @@ def sh(
max_retries: the number of scheduler retries allowed
mounts: mounts to mount into the worker environment/container (ex. type=<bind/volume>,src=/host,dst=/job[,readonly]).
See scheduler documentation for more info.
entrypoint: the entrypoint to use for the command (defaults to sh)
"""

escaped_args = " ".join(shlex.quote(arg) for arg in args)
Expand All @@ -113,7 +115,7 @@ def sh(
specs.Role(
name="sh",
image=image,
entrypoint="sh",
entrypoint=entrypoint or "sh",
args=["-c", escaped_args],
num_replicas=num_replicas,
resource=specs.resource(cpu=cpu, gpu=gpu, memMB=memMB, h=h),
Expand Down
Loading