warn on unknown runopt passed via command-line #1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Summary: When you pass an invalid scheduler arg via the .torchxconfig file, we get a warning about it. This change adds a similar warning when the scheduler arg is passed via a command-line argument. (background: I spent a few hours yesterday debugging a torchx command for a job until spotting a typo in one of the arguments) Differential Revision: D70562266
|
This pull request was exported from Phabricator. Differential Revision: D70562266 |
|
This pull request was exported from Phabricator. Differential Revision: D70562266 |
daniel-ohayon
force-pushed
the
export-D70562266
branch
from
c44c0ad to
a8f9505
Compare
lgarg26
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When you pass an invalid scheduler arg via the .torchxconfig file, we get a warning about it.
This change adds a similar warning when the scheduler arg is passed via a command-line argument.
(background: I spent a few hours yesterday debugging a torchx command for a job until spotting a typo in one of the arguments)
Differential Revision: D70562266