Skip to content

Fix flaky compute_world_size test on devservers and make pyre happy #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Fix flaky compute_world_size test on devservers and make pyre happy #1030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions torchx/examples/apps/compute_world_size/config/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Copyright (c) Meta Platforms, Inc. and affiliates.
# All rights reserved.
#
# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree.
4 changes: 2 additions & 2 deletions torchx/examples/apps/compute_world_size/module/test/util_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ def test_compute_world_size(self) -> None:
"rank": 0,
"world_size": 1,
"master_addr": "localhost",
# ephemeral port range in linux
"master_port": random.randint(32768, 60999),
# specifying 0 as master_port makes TCPStore chose a free random port
"master_port": 0,
"backend": "gloo",
}
}
Expand Down
Loading