Improve _get_path_to_function_decl to handle function wrapper with class #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
nghuiqin
added a commit
to nghuiqin/torchx
that referenced
this pull request
Sep 15, 2025
…ass (meta-pytorch#1116) Summary: We added file decorator support in meta-pytorch#1111 **Problem:** This will fail when the function wrapper with dataclass object **Fix:** Determine if decorators found in function before unwrap. Add two test cases to cover: * comp_f using dataclass in g.py => should return __init__.py * comp_g using decorator in h.py => should return g.py Differential Revision: D82346696
nghuiqin
force-pushed
the
export-D82346696
branch
from
9bb03a6 to
e6c1e46
Compare
nghuiqin
added a commit
to nghuiqin/torchx
that referenced
this pull request
Sep 15, 2025
…ass (meta-pytorch#1116) Summary: We added file decorator support in meta-pytorch#1111 **Problem:** This will fail when the function wrapper with dataclass object **Fix:** Determine if decorators found in function before unwrap. Add two test cases to cover: * comp_f using dataclass in g.py => should return __init__.py * comp_g using decorator in h.py => should return g.py Differential Revision: D82346696
nghuiqin
force-pushed
the
export-D82346696
branch
from
e6c1e46 to
58ee6b0
Compare
nghuiqin
added a commit
to nghuiqin/torchx
that referenced
this pull request
Sep 15, 2025
…ass (meta-pytorch#1116) Summary: We added file decorator support in meta-pytorch#1111 **Problem:** This will fail when the function wrapper with dataclass object **Fix:** Determine if decorators found in function before unwrap. Add two test cases to cover: * comp_f using dataclass in g.py => should return __init__.py * comp_g using decorator in h.py => should return g.py Differential Revision: D82346696
nghuiqin
force-pushed
the
export-D82346696
branch
from
58ee6b0 to
d5eec75
Compare
nghuiqin
added a commit
to nghuiqin/torchx
that referenced
this pull request
Sep 15, 2025
…ass (meta-pytorch#1116) Summary: We added file decorator support in meta-pytorch#1111 **Problem:** This will fail when the function wrapper with dataclass object **Fix:** Determine if decorators found in function before unwrap. Add two test cases to cover: * comp_f using dataclass in g.py => should return __init__.py * comp_g using decorator in h.py => should return g.py Differential Revision: D82346696
nghuiqin
force-pushed
the
export-D82346696
branch
from
d5eec75 to
adaced3
Compare
nghuiqin
added a commit
to nghuiqin/torchx
that referenced
this pull request
Sep 15, 2025
…ass (meta-pytorch#1116) Summary: We added file decorator support in meta-pytorch#1111 **Problem:** This will fail when the function wrapper with dataclass object **Fix:** Determine if decorators found in function before unwrap. Add two test cases to cover: * comp_f using dataclass in g.py => should return __init__.py * comp_g using decorator in h.py => should return g.py Differential Revision: D82346696
nghuiqin
force-pushed
the
export-D82346696
branch
from
adaced3 to
47c01b1
Compare
nghuiqin
added a commit
to nghuiqin/torchx
that referenced
this pull request
Sep 15, 2025
…ass (meta-pytorch#1116) Summary: We added file decorator support in meta-pytorch#1111 **Problem:** This will fail when the function wrapper with dataclass object **Fix:** Determine if decorators found in function before unwrap. Add two test cases to cover: * comp_f using dataclass in g.py => should return __init__.py * comp_g using decorator in h.py => should return g.py Reviewed By: ethanbwaite Differential Revision: D82346696
nghuiqin
force-pushed
the
export-D82346696
branch
from
47c01b1 to
366bea8
Compare
…ass (meta-pytorch#1116) Summary: We added file decorator support in meta-pytorch#1111 **Problem:** This will fail when the function wrapper with dataclass object **Fix:** Determine if decorators found in function before unwrap. Add two test cases to cover: * comp_f using dataclass in g.py => should return __init__.py * comp_g using decorator in h.py => should return g.py Reviewed By: ethanbwaite Differential Revision: D82346696
nghuiqin
force-pushed
the
export-D82346696
branch
from
366bea8 to
3664285
Compare
ethanbwaite
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We added file decorator support in #1111
Problem: This will fail when the function wrapper with dataclass object
Fix: Determine if decorators found in function before unwrap.
Add two test cases to cover:
Differential Revision: D82346696