Skip to content

Conversation

kiukchung
Copy link
Contributor

Summary: role.base_image has been marked for deprecation for a few years. Remove it.

Differential Revision: D83780899

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2025
@facebook-github-bot
Copy link
Contributor

@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83780899.

facebook-github-bot pushed a commit that referenced this pull request Oct 6, 2025
Summary:

`role.base_image` has been marked for deprecation for a few years. Remove it.

Reviewed By: richardwang-at-fb

Differential Revision: D83780899
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.64%. Comparing base (b376e8c) to head (59d6432).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1138      +/-   ##
==========================================
- Coverage   91.64%   91.64%   -0.01%     
==========================================
  Files          83       83              
  Lines        6441     6440       -1     
==========================================
- Hits         5903     5902       -1     
  Misses        538      538              
Flag Coverage Δ
unittests 91.64% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

facebook-github-bot pushed a commit that referenced this pull request Oct 7, 2025
Summary:

`role.base_image` has been marked for deprecation for a few years. Remove it.

Reviewed By: richardwang-at-fb

Differential Revision: D83780899
Copy link

meta-codesync bot commented Oct 7, 2025

@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83780899.

Summary:

`role.base_image` has been marked for deprecation for a few years. Remove it.

Reviewed By: richardwang-at-fb

Differential Revision: D83780899
@meta-codesync meta-codesync bot merged commit 6c03c7e into main Oct 11, 2025
20 of 22 checks passed
@meta-codesync meta-codesync bot deleted the export-D83780899 branch October 11, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants