Skip to content

Conversation

@AbishekS
Copy link
Contributor

Summary:
The changes in previous diffs make the API usages too verbose

  1. So in this we revert cfg_key back to a string type and
  2. add aliases as list and
  3. deprecated_aliases as list.
  4. Auto aliasing has been modified as well of type bool, default to be true and only applied to the cfg_key.
opts.add(
  name="rmAttribution",
  aliases=["tenant"],
  deprecated_aliases = ["RmAttr"],
  auto_aliases=True,
)
  1. Also modify all the changes made in D85248506

Differential Revision: D85591292

@meta-codesync
Copy link

meta-codesync bot commented Oct 27, 2025

@AbishekS has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85591292.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 27, 2025
Summary:

The changes in previous diffs make the API usages too verbose
1. So in this we revert cfg_key back to a string type and 
2. add aliases as list and 
3. deprecated_aliases as list. 
4. Remove auto aliasing completely
```
opts.add(
  name="rmAttribution",
  aliases=["tenant"],
  deprecated_aliases = ["RmAttr"],
)
```

5. Also modify all the changes made in D85248506. Note we are keeping the camelcase as the main name and the snake case as the alias because of downstream issues and inconsistencies. 
6. Make some fixes in the mast schedulers to accommodate this change

Differential Revision: D85591292
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.61%. Comparing base (7f68b89) to head (c382d3c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
- Coverage   91.61%   91.61%   -0.01%     
==========================================
  Files          84       84              
  Lines        6644     6583      -61     
==========================================
- Hits         6087     6031      -56     
+ Misses        557      552       -5     
Flag Coverage Δ
unittests 91.61% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meta-codesync meta-codesync bot merged commit 7abb9a2 into meta-pytorch:main Oct 29, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants