clean pod labels for any invalid characters #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85796595. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1157 +/- ##
=======================================
Coverage 91.61% 91.62%
=======================================
Files 84 84
Lines 6583 6589 +6
=======================================
+ Hits 6031 6037 +6
Misses 552 552
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kiukchung
added a commit
that referenced
this pull request
Oct 30, 2025
Summary: Pull Request resolved: #1157 Reported on `torchx.__version__` since torchx follows PEP-440 standards for the version string, it could be that certain `torchx` builds (specifically those that are built from source) could have a "local label". For example: `0.8.0dev0+fb` would be a Meta "local build". Added logic to clean the pod label values to meet k8s specs specified in https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/ Specifically: ``` Valid label value: * must be 63 characters or less (can be empty), unless empty * must begin and end with an alphanumeric character ([a-z0-9A-Z]) * could contain dashes (-), underscores (_), dots (.), and alphanumerics between. ``` We first replace any invalid chars with a valid one (`"."`) and finally truncate each pod label value to a MAX length of 63. Reviewed By: ndacosta, AbishekS Differential Revision: D85796595
kiukchung
force-pushed
the
export-D85796595
branch
2 times, most recently
from
6e98b19 to
fdd738a
Compare
kiukchung
added a commit
that referenced
this pull request
Oct 30, 2025
Summary: Pull Request resolved: #1157 Reported on `torchx.__version__` since torchx follows PEP-440 standards for the version string, it could be that certain `torchx` builds (specifically those that are built from source) could have a "local label". For example: `0.8.0dev0+fb` would be a Meta "local build". Added logic to clean the pod label values to meet k8s specs specified in https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/ Specifically: ``` Valid label value: * must be 63 characters or less (can be empty), unless empty * must begin and end with an alphanumeric character ([a-z0-9A-Z]) * could contain dashes (-), underscores (_), dots (.), and alphanumerics between. ``` We first replace any invalid chars with a valid one (`"."`) and finally truncate each pod label value to a MAX length of 63. Reviewed By: ndacosta, AbishekS Differential Revision: D85796595
kiukchung
added a commit
that referenced
this pull request
Oct 30, 2025
Summary: Pull Request resolved: #1157 Reported on `torchx.__version__` since torchx follows PEP-440 standards for the version string, it could be that certain `torchx` builds (specifically those that are built from source) could have a "local label". For example: `0.8.0dev0+fb` would be a Meta "local build". Added logic to clean the pod label values to meet k8s specs specified in https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/ Specifically: ``` Valid label value: * must be 63 characters or less (can be empty), unless empty * must begin and end with an alphanumeric character ([a-z0-9A-Z]) * could contain dashes (-), underscores (_), dots (.), and alphanumerics between. ``` We first replace any invalid chars with a valid one (`"."`) and finally truncate each pod label value to a MAX length of 63. Reviewed By: ndacosta, AbishekS Differential Revision: D85796595
kiukchung
force-pushed
the
export-D85796595
branch
from
fdd738a to
a9419d1
Compare
Summary: Reported on `torchx.__version__` since torchx follows PEP-440 standards for the version string, it could be that certain `torchx` builds (specifically those that are built from source) could have a "local label". For example: `0.8.0dev0+fb` would be a Meta "local build". Added logic to clean the pod label values to meet k8s specs specified in https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/ Specifically: ``` Valid label value: * must be 63 characters or less (can be empty), unless empty * must begin and end with an alphanumeric character ([a-z0-9A-Z]) * could contain dashes (-), underscores (_), dots (.), and alphanumerics between. ``` We first replace any invalid chars with a valid one (`"."`) and finally truncate each pod label value to a MAX length of 63. Reviewed By: ndacosta, AbishekS Differential Revision: D85796595
facebook-github-bot
force-pushed
the
export-D85796595
branch
from
a9419d1 to
af49af4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reported on
torchx.__version__since torchx follows PEP-440 standards for the version string, it could be that certaintorchxbuilds (specifically those that are built from source) could have a "local label".For example:
0.8.0dev0+fbwould be a Meta "local build".Added logic to clean the pod label values to meet k8s specs specified in https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/
Specifically:
We first replace any invalid chars with a valid one (
".") and finally truncate each pod label value to a MAX length of 63.Reviewed By: ndacosta, AbishekS
Differential Revision: D85796595