torchx - profile scheduler validate call #972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66166216 |
tonykao8080
pushed a commit
to tonykao8080/torchx
that referenced
this pull request
Nov 25, 2024
Summary: track torchx scheduler validate() call. Will capture elapse time and whether validation failed. There is no behavior impact to torchx users as this change only add logging for monitoring purpose verified scuba log has the validate record: https://fburl.com/scuba/pytorch_elastic_tsm_log/jza7f33n Differential Revision: D66166216
tonykao8080
force-pushed
the
export-D66166216
branch
from
da75cdc to
379d70d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66166216 |
tonykao8080
pushed a commit
to tonykao8080/torchx
that referenced
this pull request
Dec 2, 2024
Summary: track torchx scheduler validate() call. Will capture elapse time and whether validation failed. There is no behavior impact to torchx users as this change only add logging for monitoring purpose verified scuba log has the validate record: https://fburl.com/scuba/pytorch_elastic_tsm_log/jza7f33n Differential Revision: D66166216
tonykao8080
force-pushed
the
export-D66166216
branch
from
379d70d to
122cc26
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66166216 |
|
The unittest failed, is it not related to this change ? |
Yes, looks like test issue is related to this change. will fix |
tonykao8080
pushed a commit
to tonykao8080/torchx
that referenced
this pull request
Dec 9, 2024
Summary: track torchx scheduler validate() call. Will capture elapse time and whether validation failed. There is no behavior impact to torchx users as this change only add logging for monitoring purpose verified scuba log has the validate record: https://fburl.com/scuba/pytorch_elastic_tsm_log/jza7f33n Differential Revision: D66166216
tonykao8080
force-pushed
the
export-D66166216
branch
from
122cc26 to
69bc841
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66166216 |
Summary: track torchx scheduler validate() call. Will capture elapse time and whether validation failed. There is no behavior impact to torchx users as this change only add logging for monitoring purpose verified scuba log has the validate record: https://fburl.com/scuba/pytorch_elastic_tsm_log/jza7f33n Differential Revision: D66166216
tonykao8080
force-pushed
the
export-D66166216
branch
from
69bc841 to
c7a8a46
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66166216 |
jesszzzz
approved these changes
Jan 10, 2025
yikaiMeta
approved these changes
Jan 10, 2025
facebook-github-bot
merged commit ffb6cef
into
meta-pytorch:main
22 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
track torchx scheduler validate() call. Will capture elapse time and whether validation failed. There is no behavior impact to torchx users as this change only add logging for monitoring purpose
verified scuba log has the validate record:
https://fburl.com/scuba/pytorch_elastic_tsm_log/jza7f33n
Differential Revision: D66166216