Skip to content

Conversation

Sanjay-Ganeshan
Copy link
Contributor

Summary:
For some reason, certain jobs have logs that end in \n\n, making unreadable whitespace

This diff explicitly strips lines before prefixing them, and then manually adds back exactly one "\n"

Created from CodeHub with https://fburl.com/edit-in-codehub

Reviewed By: haonans

Differential Revision: D66191123

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66191123

Copy link
Contributor

@tonykao8080 tonykao8080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Summary:

For some reason, certain jobs have logs that end in \n\n, making unreadable whitespace

This diff explicitly strips lines before prefixing them, and then manually adds back exactly one "\n"

Created from CodeHub with https://fburl.com/edit-in-codehub

Reviewed By: haonans, tonykao8080

Differential Revision: D66191123
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66191123

@facebook-github-bot facebook-github-bot merged commit cb0e457 into meta-pytorch:main Dec 3, 2024
15 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants