[torchx/lintrunner] Propagate pyre cmd errors in pyre_linter.py #979
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PYRE check for
lintrunner
doesn't check the return code of runningsubprocess.run(["pyre", "--output=json", "incremental"])
therefore will try to parse the content of the command's console output as json even if the command fails.This results in the propagated error message being non-descriptive.
Before
Before the change
pyre --output=json incremental
failing would result in:After
After this fix, we get the proper root cause