sync torchx .pyre_configuration.internal with external config and upg… #986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
stroxler
force-pushed
the
try-fix-torchx
branch
from
64a9896 to
ed89ee9
Compare
|
@stroxler has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
stroxler
added a commit
to stroxler/torchx
that referenced
this pull request
Dec 10, 2024
meta-pytorch#986) Summary: There are some issues with Pyre versions in github CI, and at the moment we aren't getting type errors. Making a PR to (a) bump to Ubuntu 24.04, because the root cause is a glibc issue (b) upgrade to the 2024-11-25 release (c) suppress errors I'm making a fresh PR because the original one doesn't seem to trigger github CI (maybe because it was exported from a diff) Test Plan: Ran github CI, the problem is fixed. Reviewed By: jesszzzz Differential Revision: D66994745 Pulled By: stroxler
stroxler
force-pushed
the
try-fix-torchx
branch
from
90287c4 to
f34f893
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66994745 |
|
This pull request was exported from Phabricator. Differential Revision: D66994745 |
stroxler
added a commit
to stroxler/torchx
that referenced
this pull request
Dec 10, 2024
meta-pytorch#986) Summary: There are some issues with Pyre versions in github CI, and at the moment we aren't getting type errors. Making a PR to (a) bump to Ubuntu 24.04, because the root cause is a glibc issue (b) upgrade to the 2024-11-25 release (c) suppress errors I'm making a fresh PR because the original one doesn't seem to trigger github CI (maybe because it was exported from a diff) Test Plan: Ran github CI, the problem is fixed. Reviewed By: jesszzzz Differential Revision: D66994745 Pulled By: stroxler
stroxler
force-pushed
the
try-fix-torchx
branch
from
f34f893 to
e70a24c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66994745 |
meta-pytorch#986) Summary: There are some issues with Pyre versions in github CI, and at the moment we aren't getting type errors. Making a PR to (a) bump to Ubuntu 24.04, because the root cause is a glibc issue (b) upgrade to the 2024-11-25 release (c) suppress errors I'm making a fresh PR because the original one doesn't seem to trigger github CI (maybe because it was exported from a diff) Test Plan: Ran github CI, the problem is fixed. Reviewed By: jesszzzz Differential Revision: D66994745 Pulled By: stroxler
stroxler
force-pushed
the
try-fix-torchx
branch
from
e70a24c to
423ec06
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66994745 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some issues with Pyre versions in github CI, and at the moment we aren't getting type errors.
Making a PR to
(a) upgrade to the 2024-11-25 release
(b) suppress errors
I'm making a fresh PR because the original one doesn't seem to trigger github CI (maybe because it was exported from a diff)