Skip to content

torchx - fix RaySchedulerTest unit test failure #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged

torchx - fix RaySchedulerTest unit test failure #990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion torchx/schedulers/test/ray_scheduler_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,9 @@ def test_validate_warns_when_role_contains_port_map(self) -> None:
with self._assert_log_message(
"WARNING", "The Ray scheduler does not support port mapping."
):
self._scheduler._validate(self._app_def, scheduler="ray")
self._scheduler._validate(
self._app_def, scheduler="ray", cfg=self._run_cfg
)

def test_submit_dryrun_raises_error_if_cluster_config_file_is_not_str(
self,
Expand Down
Loading