Add L2 cache clearing to do_bench_cudagraph, for more realistic timing measurement #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oulgen
approved these changes
Oct 6, 2025
|
Fantastic! Do you think we can upstream this to triton-lang/triton? |
xuzhao9
approved these changes
Oct 6, 2025
I believe so! will open a PR for this |
|
Open PR to triton-lang/triton at triton-lang/triton#8384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triton do_bench_cudagraph (link) doesn't have L2 cache clearing which makes the result unreliable. This PR adds a version of do_bench_cudagraph that has L2 cache clearing and switch tritonbench to use it.