Exclude L2 cache clear time from timing measurement #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oulgen
approved these changes
Oct 7, 2025
yf225
force-pushed
the
do_bench_cudagraph_exclude_cache_clear_time
branch
from
3069726 to
dbd40e9
Compare
xuzhao9
approved these changes
Oct 7, 2025
yf225
force-pushed
the
do_bench_cudagraph_exclude_cache_clear_time
branch
from
dbd40e9 to
0a608cd
Compare
yf225
force-pushed
the
do_bench_cudagraph_exclude_cache_clear_time
branch
from
0a608cd to
1eb387b
Compare
yf225
force-pushed
the
do_bench_cudagraph_exclude_cache_clear_time
branch
from
1eb387b to
2eb490c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
triton-lang/triton#8384 added L2 cache clearing to do_bench_cudagraph, but it includes cache clearing time in timing measurement which is wrong. This PR fixes it.