replace string loader tags with Tag enum
#588
Conversation
Use Tag enum instead of strings in `load::from_single_file`, `load::from_file` and `load::from_memory`. Prevents runtime errors from invalid tags like 'rust' instead of 'rs'.
There was a problem hiding this comment.
Good Job @abd0-omar Thanks :)
I just have a few concerns to raise.
| ptr, | ||
| }; | ||
|
|
||
| pub enum Tag { |
There was a problem hiding this comment.
I think names here in the enum has to be exactly matched with the loaders names provided here https://github.com/metacall/core/tree/develop/source/loaders.
Like Node not NodeJS
Ts not TypeScript
Rb not Ruby
and provide /// comments to show the LSP what this tag's language is, matching our Enum with the original MetaCall API.
That's my opinion, I need to know yours.
@viferga @hulxv
|
|
||
| let scripts_dir = env::current_dir().unwrap().join("tests/scripts"); | ||
| let inavlid_file = scripts_dir.join("whatever.yeet"); | ||
| let valid_file = scripts_dir.join("script.js"); |
There was a problem hiding this comment.
Why did we change this? this is supposed to be a test that points to invalid loaders.
| let js_file = scripts_dir.join("script.js"); | ||
|
|
||
| if let Err(MetaCallLoaderError::FileNotFound(_)) = | ||
| load::from_single_file("random", inavlid_file) |
There was a problem hiding this comment.
This too should be left to fail.
I guess the test at all will be outdated and removed because of the feature we implemented. The Enum will make us impossible to fail, compile-time.
|
I am going to merge it and I will change your suggestions later on @fahdfady |
3 participants
Description
Use Tag enum instead of strings in
load::from_single_file,load::from_fileandload::from_memory.Prevents runtime errors from invalid tags like "rust" instead of "rs".
Fixes #585
Type of change
Checklist:
make testorctest -VV -R <test-name>)../docker-compose.sh test &> outputand attached the output.OPTION_BUILD_ADDRESS_SANITIZERor./docker-compose.sh test-address-sanitizer &> outputandOPTION_TEST_MEMORYCHECK.OPTION_BUILD_THREAD_SANITIZERor./docker-compose.sh test-thread-sanitizer &> output.Helgrindin case my code works with threading.make clang-formatin order to format my code and my code follows the style guidelines.If you are unclear about any of the above checks, have a look at our documentation here.