Consider all machines of partition for evaluating faulty machines #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal-robot
bot
added
the
area: control-plane
…pacity-endpoint-faulty-machine-evaluation
ostempel
requested review from
Gerrit91 and
mwennrich
and removed request for
mwennrich
Gerrit91
changed the title
Gerrit91
changed the title
Gerrit91
reviewed
Sep 2, 2025
| return nil, err | ||
| } | ||
| } else { | ||
| allMs = ms |
Contributor
There was a problem hiding this comment.
ms could be filtered by size, so these are not all machines. There should be no other filters applied for machine evaluation (except maybe partition).
Contributor
Author
There was a problem hiding this comment.
yeah totally right. I will fix this
Gerrit91
approved these changes
Sep 22, 2025
Contributor
Gerrit91
left a comment
Gerrit91
left a comment
There was a problem hiding this comment.
Thanks, hopefully it will fix the issue in production, too, but I think it will!
Gerrit91
deleted the
fix-capacity-endpoint-faulty-machine-evaluation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #623
Consider all machines of partition (if partition filter is set) for evaluating faulty machines.