Major Refactor: Code Modernization, New Features, and Documentation #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The member variable `results` in the `DecisionNode` class was ambiguous and required a comment to explain its purpose. This commit renames it to `class_counts` to be more descriptive and self-documenting, reflecting that it holds the distribution of training samples in a leaf node. The conditional checks have also been updated to be more idiomatic (e.g., `if node.class_counts:`).
+ adult dataset
Improves the core algorithm's efficiency by refactoring the impurity and pruning calculations to operate on Counter objects directly, avoiding the creation of large temporary data lists. - Adopts PEP 8 naming conventions and adds type hints. - Fixes a potential ZeroDivisionError in missing data classification. - Simplifies pre-pruning logic in the tree growth algorithm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Michael,
Thank you for creating this excellent educational repository for decision trees.
As I was working with the code, I made some updates to modernise it, improve its usability, and add proper documentation. I wanted to offer these changes back to the original project in case they are useful to you or to future learners who find this repo.
Here is a summary of the improvements:
Code Modernization & Refactoring:
New Features & Usability:
Project Structure & Documentation:
No pressure to merge this, as I know the project is not actively maintained, but I wanted to offer these improvements back. Thanks again for the great resource!