Updating packages for compatability with Swashbuckle.AspNetCore.Swagg… #161
Conversation
…erGen 8 and getting rid of some legacy package dependencies. Looks like Should take care of issues micro-elements#158 and micro-elements#160. One issue is the newer versions of Swashbuckle.AspNetCore.SwaggerGen made SwaggerMiddleware internal (see domaindrivendev/Swashbuckle.AspNetCore#2805). This breaks the scoped middleware, not sure if this is still needed as I have not used in a project
|
Hey @petriashev can you please take a look at this PR? |
samples/MinimalApi/MinimalApi.csproj
Outdated
| <PackageReference Include="MicroElements.Swashbuckle.FluentValidation" Version="6.0.0" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="7.0.2" /> | ||
| <PackageReference Include="Swashbuckle.AspNetCore" Version="6.4.0" /> | ||
| <PackageReference Include="FluentValidation.AspNetCore" Version="11.3.0" /> |
There was a problem hiding this comment.
This package is no longer maintained. See:
https://www.nuget.org/packages/FluentValidation.AspNetCore/
There was a problem hiding this comment.
Yeah I have a couple other changes i would make but no response from the owner so not worth putting more effort forward in here
There was a problem hiding this comment.
I get it. It has happened to me so many times that I just don't do OSS contributions.
|
Adding one more update to see if we can get any discussion from @petriashev. Otherwise I will probably end up forking this and publishing a trimmed down version without some of the features I don't use in projects. Just to try, I added @vchirikov workaround for the scoped middleware becoming internal. Not sure I like forcing access into their API surface like that, but I don't see any other options. The readme and other supporting docs will need updates if we can move this forward, but not going to spend the time updating here if the author is done with maintenance. I do want to add a thank you to Alexey for this project, it has been useful for both work and personal projects in the last couple years. I understand the time cost of OSS doesn't lend to these sorts of packages being maintained forever, but grateful for your work in filling the niche that was needed at the time. |
4 participants
Thought I would take a crack at updating packages for compatibility with Swashbuckle.AspNetCore.SwaggerGen 8.0.0 and getting rid of some legacy package dependencies. There are two changes here I am not sure how you feel about and may not be a usable solution to you, but I wanted to get a discussion going around them.
Other packages I have built have moved on from .netstandard2.0 targeting to avoid needing to target the deprecated abstraction packages (core issue behind The 'v6.1.0' has a transitive dependency on System.Text.Encodings.Web with RCE vulnerability #158). These changes move the targeting forward to .net8 and .net9.
Swashbuckle.AspNetCore.SwaggerGen made SwaggerMiddleware internal (see Consider making more types internal domaindrivendev/Swashbuckle.AspNetCore#2805). I don't have any projects using your ScopedSwaggerMiddlewarem, so wasn't sure a good way to test any workarounds. I have deleted in this branch, but obviously that could change if you have thoughts on working around the issue
Maybe this PR doesn't work for what you want here, but I thought it could be a good starting point for you in resolving those two open issues.